-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(HLS): Fix detection of WebVTT subtitles in HLS by extension #4928
fix(HLS): Fix detection of WebVTT subtitles in HLS by extension #4928
Conversation
Incremental code coverage: 100.00% |
Commented on the issue, but putting it here as well: There seems to be a deeper issue in Does shaka pre-guess and assign "text/vtt" mime type for some tracks, regardless of extension, but not all? I haven't debugged it fully, the PR provided by Fredrik fixes the issue by correcting the bad mime type, but it's confusing me why shaka would choose two different ones for near identical tracks. |
Essentially, yes. We don't know the extension until we load the playlist, and since v4.3.0, we only load the playlists of tracks that we are streaming. Sorry for the trouble, and the typo, and thanks for the fix! |
We were seeing uncaught TypeErrors when changing subbtitle tracks. Closes #4929
We were seeing uncaught TypeErrors when changing subbtitle tracks. Closes #4929
We were seeing uncaught TypeErrors when changing subbtitle tracks. Closes #4929
We were seeing uncaught TypeErrors when changing subbtitle tracks. Closes #4929
Was this a typo? We were seeing uncaught TypeErrors when changing subtitle tracks related to this, it seems
'txt/vtt'
is not a valid mime type for webvtt subtitles.Closes #4929