Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add Occitan locale #4900

Merged
merged 1 commit into from
Jan 17, 2023
Merged

feat(i18n): add Occitan locale #4900

merged 1 commit into from
Jan 17, 2023

Conversation

Mejans
Copy link
Contributor

@Mejans Mejans commented Jan 14, 2023

I hope I made the proper changes

@google-cla
Copy link

google-cla bot commented Jan 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Mejans Mejans changed the title i18n: add Occitan locale feat: i18n => add Occitan locale Jan 15, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

@avelad avelad requested a review from joeyparrish January 16, 2023 09:27
@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P4 Nice to have / wishful thinking labels Jan 16, 2023
@theodab
Copy link
Contributor

theodab commented Jan 17, 2023

Yeah, that's all you need to do to add a new localization.
You will need to sign the CLA, though. See CONTRIBUTING.md.

@joeyparrish
Copy link
Member

The CLA bot is happy now, so I'll go ahead and merge. Thank you for your contribution!

@joeyparrish joeyparrish changed the title feat: i18n => add Occitan locale feat(i18n): add Occitan locale Jan 17, 2023
@joeyparrish joeyparrish merged commit 68486a3 into shaka-project:main Jan 17, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants