fix: Make encoding problem detection more robust #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, tiny segments (~33ms in practice) and overwritten segments (sometimes necessary) would register as encoding problems. This makes the logic more robust and the error logs more reliable. Issue shaka-project#4589
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo and
theodab
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
avelad
approved these changes
Jan 12, 2023
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
Before, tiny segments (~33ms in practice) and overwritten segments (sometimes necessary) would register as encoding problems. This makes the logic more robust and the error logs more reliable. Issue #4589
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
Before, tiny segments (~33ms in practice) and overwritten segments (sometimes necessary) would register as encoding problems. This makes the logic more robust and the error logs more reliable. Issue #4589
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
Before, tiny segments (~33ms in practice) and overwritten segments (sometimes necessary) would register as encoding problems. This makes the logic more robust and the error logs more reliable. Issue shaka-project#4589
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, tiny segments (~33ms in practice) and overwritten segments (sometimes necessary) would register as encoding problems. This makes the logic more robust and the error logs more reliable.
Issue #4589