Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix flattenedCues in WebVttGenerator #4867

Merged
merged 2 commits into from
Jan 5, 2023
Merged

fix: Fix flattenedCues in WebVttGenerator #4867

merged 2 commits into from
Jan 5, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 4, 2023 •
edited
Loading

Fixes #4856

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Jan 4, 2023
@avelad avelad added this to the v4.4 milestone Jan 4, 2023
@avelad avelad mentioned this pull request Jan 4, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Incremental code coverage: 93.33%

@avelad avelad merged commit 15232dd into shaka-project:main Jan 5, 2023
@github-actions github-actions bot mentioned this pull request Jan 5, 2023
Merged
@avelad avelad deleted the flattenedCues-webvtt-generator branch January 6, 2023 18:08
joeyparrish pushed a commit that referenced this pull request Jan 13, 2023
@avelad @joeyparrish
fix: Fix flattenedCues in WebVttGenerator (#4867)
e062175 
Fixes #4856
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Jan 13, 2023
@avelad @joeyparrish
fix: Fix flattenedCues in WebVttGenerator (#4867)
2b37820 
Fixes #4856
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Jan 13, 2023
@avelad @joeyparrish
fix: Fix flattenedCues in WebVttGenerator (#4867)
45af59e 
Fixes #4856
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Jan 13, 2023
@avelad @joeyparrish
fix: Fix flattenedCues in WebVttGenerator (#4867)
1a69a22 
Fixes #4856
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Feb 8, 2023
@avelad
fix: Fix flattenedCues in WebVttGenerator (shaka-project#4867)
bf22f06 
Fixes shaka-project#4856
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex littlespex approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Cannot add subtitle when loading a video without a manifest directly
3 participants
@avelad @littlespex @joeyparrish