Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Fix support for mixed AES-128/NONE decryption #4847

Merged
merged 1 commit into from
Jan 9, 2023
Merged

fix(HLS): Fix support for mixed AES-128/NONE decryption #4847

merged 1 commit into from
Jan 9, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 20, 2022

fixes #4846

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Dec 20, 2022
@avelad avelad added this to the v4.4 milestone Dec 20, 2022
@avelad avelad mentioned this pull request Dec 20, 2022
Closed
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad
Copy link
Member Author

avelad commented Jan 9, 2023

@joeyparrish can you review it? Thanks!

@avelad avelad requested a review from littlespex January 9, 2023 19:04
@avelad avelad merged commit 452694d into shaka-project:main Jan 9, 2023
@avelad avelad deleted the hls-key-none branch January 9, 2023 19:20
@github-actions github-actions bot mentioned this pull request Jan 9, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Jan 13, 2023
@avelad @joeyparrish
fix(HLS): Fix support for mixed AES-128/NONE decryption (#4847)
d495255 
fixes #4846
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Jan 13, 2023
@avelad @joeyparrish
fix(HLS): Fix support for mixed AES-128/NONE decryption (#4847)
e866903 
fixes #4846
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Feb 8, 2023
@avelad
fix(HLS): Fix support for mixed AES-128/NONE decryption (shaka-projec…
8cf641a 
…t#4847)

fixes shaka-project#4846
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

HLS KEY None Decryption Support
2 participants
@avelad @joeyparrish