fix(HLS): Fix detection of Media Playlist for audio and video only in MP4 #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
force-pushed
the
media-playlist
branch
from
3afeece to
ea79350
Compare
|
Incremental code coverage: 46.67% |
joeyparrish
reviewed
Dec 8, 2022
| if (mimeType) { | ||
| fullMimeType = mimeType; | ||
| } else if (extension === 'ts') { | ||
| // TODO: Fetch one segment a use the TsParser to analize if there is |
There was a problem hiding this comment.
Do you prefer any other way?
There was a problem hiding this comment.
I don't love fetching segments for analysis. We quit doing it for timestamps, and I don't want to go back.
This is probably not as bad, since it's a media playlist, so we will only ever fetch one segment. I still wish we had another way. But Apple didn't design HLS for MediaSource, so it's tough to make things like this work without probing into the segments.
joeyparrish
approved these changes
Dec 8, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.