Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TTML): Add font-family mapping #4801

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 8, 2022

Closes #4749

@avelad avelad requested review from theodab and joeyparrish December 8, 2022 18:29
@avelad avelad added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Dec 8, 2022
@avelad avelad added this to the v4.4 milestone Dec 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Incremental code coverage: 60.00%

@theodab theodab merged commit db8987d into shaka-project:main Dec 8, 2022
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
@avelad avelad deleted the ttml-font-family branch December 8, 2022 19:45
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Feb 8, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: TTML The issue involves TTML subtitles specifically component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font family mapping in UITextDisplayer
3 participants