-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TTML): Add font-family mapping #4801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
Something isn't working correctly
component: TTML
The issue involves TTML subtitles specifically
component: UI
The issue involves the Shaka Player UI
priority: P2
Smaller impact or easy workaround
labels
Dec 8, 2022
joeyparrish
approved these changes
Dec 8, 2022
Incremental code coverage: 60.00% |
theodab
approved these changes
Dec 8, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: TTML
The issue involves TTML subtitles specifically
component: UI
The issue involves the Shaka Player UI
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4749