Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move forceTransmux from streaming to mediasource config #4783

Merged
merged 2 commits into from
Dec 7, 2022
Merged

feat: Move forceTransmux from streaming to mediasource config #4783

merged 2 commits into from
Dec 7, 2022

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 3, 2022

No description provided.

@avelad avelad added type: code health A code health issue priority: P2 Smaller impact or easy workaround labels Dec 3, 2022
@avelad avelad added this to the v4.4 milestone Dec 3, 2022
@avelad avelad requested review from joeyparrish and theodab December 3, 2022 08:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Incremental code coverage: 33.33%

@avelad
Merge branch 'main' into mediasource-forcetransmux
847e476 
# Conflicts:
#	lib/media/media_source_engine.js
joeyparrish
joeyparrish approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think this technically needs to be a "feat". I don't think this should be cherry-picked to existing branches.

@joeyparrish joeyparrish changed the title chore: move forceTransmux from streaming to mediasource config feat: Move forceTransmux from streaming to mediasource config Dec 7, 2022
@joeyparrish joeyparrish merged commit b491a6b into shaka-project:main Dec 7, 2022
@github-actions github-actions bot mentioned this pull request Dec 7, 2022
Merged
@avelad avelad deleted the mediasource-forcetransmux branch December 8, 2022 17:56
swac pushed a commit to loomhq/shaka-player that referenced this pull request Feb 9, 2023
@avelad @swac
feat: Move forceTransmux from streaming to mediasource config (shaka-…
33c7861 
…project#4783)
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: code health A code health issue
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @joeyparrish