fix(ui): Check event cancelable before event.preventDefault #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 0.00% |
avelad
added
type: bug
joeyparrish
approved these changes
Nov 11, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
This error occurs when the first touch is initiated: [Intervention] Ignored attempt to cancel a touchstart event with cancelable=false, for example because scrolling is in progress and cannot be interrupted. Added logic to confirm that the error can be cancelled before event.preventDefault.
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
This error occurs when the first touch is initiated: [Intervention] Ignored attempt to cancel a touchstart event with cancelable=false, for example because scrolling is in progress and cannot be interrupted. Added logic to confirm that the error can be cancelled before event.preventDefault.
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
This error occurs when the first touch is initiated: [Intervention] Ignored attempt to cancel a touchstart event with cancelable=false, for example because scrolling is in progress and cannot be interrupted. Added logic to confirm that the error can be cancelled before event.preventDefault.
joeyparrish
pushed a commit
that referenced
this pull request
Dec 8, 2022
This error occurs when the first touch is initiated: [Intervention] Ignored attempt to cancel a touchstart event with cancelable=false, for example because scrolling is in progress and cannot be interrupted. Added logic to confirm that the error can be cancelled before event.preventDefault.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This error occurs when the first touch is initiated.
Added logic to confirm that the error can be cancelled before event.preventDefault.