fix: Fix detection of ac4, dts, and dolby h265 #4657
Conversation
avelad
added
type: enhancement
|
Incremental code coverage: 100.00% |
lib/util/manifest_parser_utils.js
Outdated
| @@ -183,6 +184,9 @@ shaka.util.ManifestParserUtils.AUDIO_CODEC_REGEXPS_ = [ | |||
| /^flac$/, | |||
| /^mp4a/, | |||
| /^[ae]c-3$/, | |||
| /^ac-4$/, | |||
| /^dts[cx]$/, | |||
| /^[du]dts$/, | |||
There was a problem hiding this comment.
Ok, all of the others I know about, or can find info about online, but what are ddts and udts?
There was a problem hiding this comment.
There was a problem hiding this comment.
But if you think it's not well-known, I'm willing to remove it.
There was a problem hiding this comment.
I don't think it needs to be removed, but perhaps a comment after the regex giving it a name would be helpful.
There was a problem hiding this comment.
I'm not 100% confident from my search results, but I'm guessing "dts" refers to "DTS Surround Sound" codecs: https://en.wikipedia.org/wiki/DTS_(company)#DTS_technologies
|
I'm in favor of classifying this as a backward-compatible "fix", since we're talking about content we can't detect and understand. How about calling this "fix: Fix detection of ac4, dts, and dolby h265"? |
avelad
changed the title
avelad
added
type: bug
Done! |
github-actions
bot
added
the
status: archived
No description provided.