Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix support clear and encrypted periods #4606

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix: fix support clear and encrypted periods #4606

merged 1 commit into from
Oct 25, 2022

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 23, 2022

Closes #4512

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels Oct 23, 2022
@avelad avelad added this to the v4.3 milestone Oct 23, 2022
@avelad avelad requested review from theodab and joeyparrish October 23, 2022 10:39
@avelad avelad mentioned this pull request Oct 23, 2022
Closed
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad merged commit 6256db3 into shaka-project:main Oct 25, 2022
@github-actions github-actions bot mentioned this pull request Oct 25, 2022
Merged
@avelad avelad deleted the clear-encrypted-periods branch October 25, 2022 17:06
joeyparrish pushed a commit that referenced this pull request Oct 26, 2022
@avelad @joeyparrish
fix: fix support clear and encrypted periods (#4606)
4c4b799 
Closes #4512
@github-actions github-actions bot mentioned this pull request Oct 26, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Oct 26, 2022
@avelad @joeyparrish
fix: fix support clear and encrypted periods (#4606)
8ece8ea 
Closes #4512
@github-actions github-actions bot mentioned this pull request Oct 26, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

Clear and encrypted periods working shaka 3.x and not 4.x
2 participants
@avelad @theodab