Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change new shaka.text.Cue() to process formatting information on the input text #4439

Closed
toschlog opened this issue Aug 24, 2022 · 3 comments · Fixed by #6992
Closed

Change new shaka.text.Cue() to process formatting information on the input text #4439

toschlog opened this issue Aug 24, 2022 · 3 comments · Fixed by #6992
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@toschlog
Copy link

Have you read the FAQ and checked for duplicate open issues?

Yes.

Is your feature request related to a problem? Please describe.

Well, I had to do a workaround, but it's only partly right.

Describe the solution you'd like

It would be super-great if new shaka.text.Cue() would parse the formatting information on the input text. For example, if the text looks like <b>This is my cue text</b> then the cue's fontWeight property should be set to "bold". This would apply to the <b>, <i>, <u>, and <v> tags.

Describe alternatives you've considered

I'm handling the three simple tags myself and setting the fontStyle, fontWeight, and textDecroration properties on the cue after calling the constructor. But the <v> tag is a bit more complex and it would be nice if shaka-player handled it.

Additional context

There is, of course, already code that does this. It's used when parsing a subtitle text file, but isn't called by the shaka.text.Cue() constructor.

@toschlog toschlog added the type: enhancement New feature or request label Aug 24, 2022
@github-actions github-actions bot added this to the Backlog milestone Aug 24, 2022
@toschlog toschlog changed the title Change new shaka.text.Cue() to process formatting information on text innput Change new shaka.text.Cue() to process formatting information on the input text Sep 6, 2022
@toschlog
Copy link
Author

toschlog commented Dec 13, 2022

If these were to be implemented, it should also handle escaped characters, such as &nbsp;.

@joeyparrish joeyparrish added priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically priority: P3 Useful but not urgent and removed priority: P2 Smaller impact or easy workaround labels Dec 13, 2022
@avelad avelad added component: captions/subtitles The issue involves captions or subtitles and removed component: WebVTT The issue involves WebVTT subtitles specifically labels Sep 12, 2023
@avelad
Copy link
Member

avelad commented Oct 25, 2023

Is anyone interested in this? The issue will be automatically closed in 7 days if no one answers. Thanks!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 25, 2023
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 1, 2023
@avelad avelad removed this from the Backlog milestone Nov 2, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 31, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 31, 2023
@avelad avelad reopened this Jul 5, 2024
@avelad avelad removed the status: archived Archived and locked; will not be updated label Jul 5, 2024
@avelad avelad added this to the v4.11 milestone Jul 5, 2024
@shaka-project shaka-project unlocked this conversation Jul 5, 2024
@avelad avelad closed this as completed in eeadace Jul 5, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 3, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants