-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change new shaka.text.Cue() to process formatting information on the input text #4439
Labels
component: captions/subtitles
The issue involves captions or subtitles
priority: P3
Useful but not urgent
status: archived
Archived and locked; will not be updated
type: enhancement
New feature or request
Milestone
Comments
If these were to be implemented, it should also handle escaped characters, such as |
Is anyone interested in this? The issue will be automatically closed in 7 days if no one answers. Thanks! |
Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: captions/subtitles
The issue involves captions or subtitles
priority: P3
Useful but not urgent
status: archived
Archived and locked; will not be updated
type: enhancement
New feature or request
Have you read the FAQ and checked for duplicate open issues?
Yes.
Is your feature request related to a problem? Please describe.
Well, I had to do a workaround, but it's only partly right.
Describe the solution you'd like
It would be super-great if
new shaka.text.Cue()
would parse the formatting information on the input text. For example, if the text looks like<b>This is my cue text</b>
then the cue'sfontWeight
property should be set to "bold". This would apply to the<b>
,<i>
,<u>
, and<v>
tags.Describe alternatives you've considered
I'm handling the three simple tags myself and setting the
fontStyle
,fontWeight
, andtextDecroration
properties on the cue after calling the constructor. But the<v>
tag is a bit more complex and it would be nice if shaka-player handled it.Additional context
There is, of course, already code that does this. It's used when parsing a subtitle text file, but isn't called by the
shaka.text.Cue()
constructor.The text was updated successfully, but these errors were encountered: