fix: Fix MediaCapabilities polyfill on Playstation 4 #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcupac Did you test this with new WebMAF 3.0? or are you working with 2.x? I was just about to submit a pretty much the same PR as this one... If this corrects the issue on that recently released MSE based WebMAF 3.0 then all good. |
agajassi
approved these changes
Jun 28, 2022
|
its for version 3.0.1 |
avelad
added
type: bug
avelad
approved these changes
Jun 28, 2022
avelad
changed the title
theodab
pushed a commit
to theodab/shaka-player
that referenced
this pull request
Jul 11, 2022
) Add Playstation 5 detection to the Media Capabilities Polyfill install method. Fixes shaka-project#4320
joeyparrish
pushed a commit
that referenced
this pull request
Jul 14, 2022
Add Playstation 5 detection to the Media Capabilities Polyfill install method. Fixes #4320
joeyparrish
pushed a commit
that referenced
this pull request
Jul 14, 2022
Add Playstation 5 detection to the Media Capabilities Polyfill install method. Fixes #4320
joeyparrish
pushed a commit
that referenced
this pull request
Jul 14, 2022
Add Playstation 5 detection to the Media Capabilities Polyfill install method. Fixes #4320
joeyparrish
pushed a commit
that referenced
this pull request
Jul 14, 2022
Add Playstation 5 detection to the Media Capabilities Polyfill install method. Fixes #4320
This was referenced Jul 14, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PS4 to the platform list, fixes an issue where ps4 was identified as an apple device/browser and explicitly sets the condition for installation of the mediaCapabilities polyfill for ps4, as its native implementation does not exist.
Closes #4315