feat: add listenable events for playback stall detection and gap jumping #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianDomingo
force-pushed
the
4227-add-listenable-events-for-playback-stall-detection-gap-jumping
branch
from
018cd97 to
70ef1c5
Compare
joeyparrish
requested changes
May 23, 2022
|
A good idea would be to compute in stats the number of times each of these events is launched |
theodab
previously requested changes
May 23, 2022
JulianDomingo
changed the title
I think this is a great idea, I've updated the Stats object to incorporate the occurrences of these events! |
JulianDomingo
force-pushed
the
4227-add-listenable-events-for-playback-stall-detection-gap-jumping
branch
2 times, most recently
from
a35f1d8 to
f201cd0
Compare
joeyparrish
requested changes
Jun 2, 2022
Additionally: - Occurrences of these new events will be propagated to the Stats object - The player event names enum is moved to util/fake_event.js so classes outside of Player can require them.
JulianDomingo
force-pushed
the
4227-add-listenable-events-for-playback-stall-detection-gap-jumping
branch
from
f201cd0 to
5675305
Compare
joeyparrish
approved these changes
Jun 2, 2022
|
Noted, thanks for the heads up! |
theodab
pushed a commit
to theodab/shaka-player
that referenced
this pull request
Jun 3, 2022
…ing (shaka-project#4249) An event `stalldetected` can be dispatched when Shaka Player detects a stall based on the value of stallThreshold through [StreamingConfiguration](https://shaka-player-demo.appspot.com/docs/api/externs_shaka_player.js.html#line920). A second event `gapjumped` could also be dispatched when Shaka performs a jump in a media gap. Related to issue shaka-project#4227
JulianDomingo
deleted the
4227-add-listenable-events-for-playback-stall-detection-gap-jumping
branch
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An event
stalldetectedcan be dispatched when Shaka Player detects a stall based on the value of stallThreshold through StreamingConfiguration.A second event
gapjumpedcould also be dispatched when Shaka performs a jump in a media gap.Related to issue #4227.