Temporarily disable streams on error

[albertdaurell]

Hi all, while testing DASH contents, for example Big Buck Bunny: the Dark Truths of a Video Dev Cartoon (DASH) if you block network requests for a quality https://storage.googleapis.com/shaka-demo-assets/bbb-dark-truths/v-0720p-2500k-libx264.mp4 in order to simulate a CDN error but only for a video quality:

    

The player does not try to switch to another quality when streaming.retryParameters.maxAttempts limit is reached.

1. Is there a setting to request the player to switch to another quality when maxAttempts limit is reached
2. Is there a way to remove/disable a variant when HTTP_ERROR is thrown?

Thank you very much

[joeyparrish]

We don't do that automatically, but it could be possible in a future version. Today AbrManager chooses tracks, but not based on errors. Ideally, we could ban (permanently or temporarily) a track with too many errors. This is discussed in #1542

[albertdaurell]

Hi @joeyparrish thanks for your quick response. I've been reading #1542 and... I started doing a POC ( seems working ok ) about how can this issue be addressed... but since I'm newbie with shaka... maybe this is not the correct way to proceed. I was wondering if you can do a quick "CR" in order to give me some feedback in order to know if I'm totally lost and this code changes are "trash" or... I'm in the correct path:

main...albertdaurell:feature/temporarily-disable-variants-on-error

[avelad]

@albertdaurell Your idea seems good and it seems that it may be related to #2541, are you interested in submitting a PR?

[albertdaurell]

I'll give a try... created! Thx!