-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove deprecated features, update upgrade guides #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping! @theodab, could you please look at this? Merging this wouldn't require us to instantly launch v4, but it would be nice to have this done and ready. |
theodab
requested changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
theodab
approved these changes
Apr 11, 2022
This was referenced May 16, 2022
This was referenced Jul 11, 2022
This was referenced Aug 11, 2022
This was referenced Aug 20, 2022
This was referenced Sep 15, 2022
This was referenced Sep 28, 2022
This was referenced Oct 10, 2022
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status: archived
Archived and locked; will not be updated
type: docs
Improvements or fixes to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below are the changelog entries for each deprecated feature removed by this commit.
feat(config)!:
manifest.dash.defaultPresentationDelay
has been replaced bymanifest.defaultPresentationDelay
(deprecated in v3.0.0)feat(config)!: Configuration of factories should be plain factory functions, not constructors; these will not be invoked with
new
(deprecated in v3.1.0)feat(player)!:
shaka.Player.prototype.addTextTrack()
has been replaced byaddTextTrackAsync()
, which returns aPromise
(deprecated in v3.1.0)feat(ui)!:
shaka.ui.TrackLabelFormat
has been renamed toshaka.ui.Overlay.TrackLabelFormat
(deprecated in v3.1.0)feat(ui)!:
shaka.ui.FailReasonCode
has been renamed toshaka.ui.Overlay.FailReasonCode
(deprecated in v3.1.0)feat(offline)!:
shaka.offline.Storage.prototype.store()
returnsAbortableOperation
instead ofPromise
(deprecated in v3.0.0)feat(offline)!:
shaka.offline.Storage.prototype.getStoreInProgress()
has been removed; concurrent operations are supported, so callers don't need to check this (deprecated in v3.0.0)feat!:
shaka.util.Uint8ArrayUtils.equal
has been replaced byshaka.util.BufferUtils.equal
, which can handle multiple types of buffers (deprecated in v3.0.0)feat(manifest)!:
shaka.media.SegmentIndex.prototype.destroy()
has been replaced byrelease()
, which is synchronous (deprecated in v3.0.0)feat(manifest)!:
shaka.media.SegmentIterator.prototype.seek()
, which mutates the iterator, has been replaced byshaka.media.SegmentIndex.getIteratorForTime()
(deprecated in v3.1.0)feat(manifest)!:
shaka.media.SegmentIndex.prototype.merge()
has become private; usemergeAndEvict()
instead (deprecated in v3.2.0)feat(plugin)!:
AbrManager
plugins must implement theplaybackRateChanged()
method (deprecated in v3.0.0)feat(plugin)!:
shaka.extern.Cue.prototype.spacer
has been replaced by the more clearly-namedlineBreak
(deprecated in v3.1.0)feat(plugin)!:
IUIElement
plugins must have arelease()
method (notdestroy()
) (deprecated in v3.0.0)