Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it recommended to take v2.5.23-master branch for production release (any master branch) #3542

Closed
kumarashu123 opened this issue Jul 22, 2021 · 4 comments
Closed

Is it recommended to take v2.5.23-master branch for production release (any master branch) #3542

kumarashu123 opened this issue Jul 22, 2021 · 4 comments
Labels
status: archived Archived and locked; will not be updated type: question A question from the community

Comments

@kumarashu123
Copy link
Contributor

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
2.5.10

Please ask your question
I wanted to upgrade with shaka player v2.5.23, I see Add support for multiple layers of nested cues. is not present in v2.5.23.
The same Add support for multiple layers of nested cues. is present in v2.5.23-master, is it recommended to take master branch v2.5.23.
@kumarashu123 kumarashu123 added the type: question A question from the community label Jul 22, 2021
@joeyparrish
Copy link
Member

No, the "-master" tags are to indicate where the master branch was at the time of a release from a release branch. We always recommend official releases from release branches.

Once a branch is created (such as v3.1.x or v3.2.x), only bug fixes are cherry-picked to that branch, and never new features. This means those branches should only ever increase in stability. Release tags such as v3.2.0 and v3.1.2 are made from the corresponding release branches.

Once you find the release branch that has the features you need (see CHANGELOG.md), then you should use the most recent release from that branch.

Does this help?

@kumarashu123
Copy link
Contributor Author

Thanks! for the quick reply
I tried upgrading 3.1.1 please see below observation

I tried playing the same VOD content with Shaka v2.5.10 and v3.1.1, v3.1.2 and found that the video start time is higher in 3.1.1, 3.1.2 compared to 2.5.10.

Same network speed, manifest url and buffering configuration was used for testing the two.

Url used: https://storage.googleapis.com/shaka-demo-assets/bbb-dark-truths/dash.mpd

Statistics:

Network bandwidth at the time of testing: 13Mbps
20 iterations were done
Avg. video start time for 2.5.10 - 2697 ms
Avg. video start time for 3.1.1 - 3090

@joeyparrish
Copy link
Member

Looks like the same comment you posted in #3508. Thank you for the report, but let's not mix issues.

Do you have any more questions about releases, tags, and branches? Or can we close this issue?

@kumarashu123
Copy link
Contributor Author

Thanks! @joeyparrish I don't have any question related to releases

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 21, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: question A question from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joeyparrish @kumarashu123 @shaka-bot