Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tizen SmartTV / Dolby audio issue, not listing dolby track when stereo track with same audio language exists at mpd #3292

Closed
dpaou opened this issue Mar 30, 2021 · 4 comments
Labels
status: archived Archived and locked; will not be updated

Comments

@dpaou
Copy link

dpaou commented Mar 30, 2021

Have you read the FAQ and checked for duplicate open issues?
Yes
Perhaps is also relevant to this issue
#1071

image

What version of Shaka Player are you using?
version 2.5.20

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Not tried

Are you using the demo app or your own custom app?
Custom application with Shaka player embedded

If custom app, can you reproduce the issue using our demo app?
Not tried

What browser and OS are you using?
Samsung Tizen 2017/2018/2019/2020 models (Tizen 3.0/Tizen 4.0/Tizen 5.0/Tizen 5.5)
"Mozilla/5.0 (SMART-TV; LINUX; Tizen 4.0) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 TV Safari/537.36"

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Samsung Tizen 2017/2018/2019/2020 models (Tizen 3.0/Tizen 4.0/Tizen 5.0/Tizen 5.5)
Indicative model QE49Q6FNA / Tizen 4.0

What are the manifest and license server URIs?

Sample manifest file
VideoOnDemand.txt

Currently there are 2 for audio track inside the .mpd file. One is ac-3 and the other is the mp4a.40.2

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

We use Shaka2 for SmartTV (Samsung Tizen). The issue is that with current VoD packaging with dual audio track (same language code, different audio codec) is not working at SmartTVs with Shaka2, dual audio streams are not listed at client side for user selection. At the moment only stereo audio track is list/available for end user.
Same asset at other platforms/player (such as Android/STB with Exoplayer) can list/select/play both audio streams.

Probably the main issue is related with the Shaka lack of presenting multiple audio streams with same language code but different codec. In the sample manifest the audio streams are ac-3 and mp4a.40.2 codecs, both with en language code :

Tizen clients do not list the ac-3 codec with the getVariantTracks() method when the mp4a.40.2 codec is available too. When we try playing the vod asset with only one audio track (ac-3 codec) it played nicely, getVariantTracks() actually listed the ac-3 codec. So, ac-3 as a codec is supported at OS level. Same is presented at SmartTV browser test

https://shaka-player-demo.appspot.com/support.html

ac-3 codec is presented
"audio/mp4; codecs="ac-3"": true,

What did you expect to happen?

List both ac-3 / mp4a.40.2 and be able to select audio track

What actually happened?

Only stereo track is available
image

@TheModMaker
Copy link
Contributor

We select the codec during startup and cannot change codecs after starting. Until #1528 is done, we can't switch codecs after starting since the browser doesn't support it.

@dpaou
Copy link
Author

dpaou commented Mar 30, 2021

Thanks for the quick and prompt reply.
The issue #1528 is related to Chrome browser. Our case is related to SmartTV with TizenOS

From user agent perspective, it seems the user agent seems to be this one :

"Mozilla/5.0 (SMART-TV; LINUX; Tizen 4.0) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 TV Safari/537.36"

In addition, we are one step prior to change codec, since track (secondary) is not even listed at getAudioLangauges()

Is it still relative to code switching and #1528?

@TheModMaker
Copy link
Contributor

Codec switching is a browser feature. Although Chrome is the first to add it, Tizen may add support eventually. So it is still relevant. Also, if codec switching isn't supported by the browser, then there is no way to switch codecs at all after playback has started.

We remove any tracks that don't match the current codec, which is why they don't appear in the track list. Once #1528 is done, we'll list them on platforms where we can switch codecs after starting. But for now, since we can't switch, we remove them from the track list.

See also #2179 for a feature to control how we select the initial codec. For now, we select the one that has the lowest bandwidth.

@dpaou
Copy link
Author

dpaou commented Mar 31, 2021

providing a preference of codecs is definetely a good idea since we can provide this as a setting to our customers so they can choose between ac-3 or stereo codecs. Seems that #2179 is related to MediaCapabilities with 3.2 target

So, will monitor the #2179

@dpaou dpaou closed this as completed Mar 31, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 30, 2021
@shaka-project shaka-project locked and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

No branches or pull requests

3 participants