Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting CORS error when trying to enable offline storage #1616

Closed
pineapplejoe opened this issue Oct 13, 2018 · 2 comments
Closed

Getting CORS error when trying to enable offline storage #1616

pineapplejoe opened this issue Oct 13, 2018 · 2 comments
Labels
status: archived Archived and locked; will not be updated

Comments

@pineapplejoe
Copy link

I have DASH media on AWS S3 - distributed via AWS CloudFront.

Cloudfront uses signed cookies to restrict access to restrict access to content.

When streaming the content with the player I use the following code to ensure that the local signed cookies get sent.

		player.getNetworkingEngine().registerRequestFilter(function(request_type, request) {
			request.allowCrossSiteCredentials = true;
		});

This works. Note that not having this code when trying to play the media will result in a CORS error.

However when I try and save the DASH content for offline use - I get a CORS error. If I add the same code above to the player that I create and pass to the offline.storage object it doesnt seem to make a difference.

I have a test environment that does not need signed cookies and the saving code works just fine. Its only when its in the production environment, which requires the signed cookies, do I then get the CORS error.

If it matters - i dont care about protecting this offline content because the person that has theability to save it has permissions to do so.

How can I get this to work?

@vaage
Copy link
Contributor

vaage commented Oct 15, 2018

@pineapplejoe next time, please use the issue template provide when creating a new issue. It will help us ensure that we have all the information we need to help you resolve your issues.

I have included below the issue template for to use for this issue. I would also ask that you include some way for our to reproduce what you are seeing.

Thanks!

Have you read the FAQ and checked for duplicate open issues?:

What version of Shaka Player are you using?:

Can you reproduce the issue with our latest release version?:

Can you reproduce the issue with the latest code from master?:

Are you using the demo app or your own custom app?:

If custom app, can you reproduce the issue using our demo app?:

What browser and OS are you using?:

What are the manifest and license server URIs?:
You can send the URIs to [email protected] instead, but please use GitHub and the template for the rest. A copy of the manifest text or an attached manifest will not be enough to reproduce your issue, and we will ask you to send a URI instead. You can copy the URI of the demo app to send us the exact asset, licence server, and settings you have selected there.

What did you do?

What did you expect to happen?

What actually happened?

@vaage vaage added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 15, 2018
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, you can ask us to reopen or have the bot reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed needs triage status: waiting on response Waiting on a response from the reporter(s) of the issue labels Oct 22, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Dec 21, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

No branches or pull requests

3 participants