fix: Fix compatibility, browser launcher detection in shaka-player #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes these launchers compatible with the older launchers we replaced, by defining DEFAULT_CMD and ENV_CMD on prototype. This allows the detection of available browser launchers in shaka-player work again. To do this, this change abstracts away several things that were previously set in the constructor so that they are now set at the class-definition level. A new function called generateSubclass handles all of these details before any instances are constructed. Closes #23
joeyparrish
force-pushed
the
fix-compat
branch
from
bee242a to
b06cb99
Compare
theodab
approved these changes
Feb 25, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes these launchers compatible with the older launchers we
replaced, by defining DEFAULT_CMD and ENV_CMD on prototype. This
allows the detection of available browser launchers in shaka-player
work again.
To do this, this change abstracts away several things that were
previously set in the constructor so that they are now set at the
class-definition level. A new function called generateSubclass
handles all of these details before any instances are constructed.
Closes #23