Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename commands to coincide with Wiki pages #314

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

hasecilu
Copy link
Contributor

@hasecilu hasecilu commented Mar 21, 2024

Same as in Fasteners WB, to be able to use the What's this? command we need to synchronize the names.

You need to choose what names you prefer to be used.

WB name Wiki name
Base AddBase
MakeWall AddWall
ExtrudeFace Extrude
FoldWall AddFoldWall
Unfold Unfold OK
UnfoldUnattended UnattendedUnfold
CornerRelief AddCornerRelief
MakeRelief AddRelief
MakeJunction AddJunction
MakeBend AddBend
SketchOnSheet SketchOnSheet OK
FormingWall Forming
BaseShape BaseShape OK

@shaise
Copy link
Owner

shaise commented Mar 22, 2024

The problem is, I think, If the command is a creation command, changing it might break old saved files. We need to test it.

@shaise
Copy link
Owner

shaise commented Mar 22, 2024

Ok, I did some checks. The saved files does not hold the command name, they hold the base class of the command. So it probably not hurt old files. It might hurt old macros, but I think this is not a big issue.

@hasecilu
Copy link
Contributor Author

hasecilu commented Mar 22, 2024

Ok, I did some checks. The saved files does not hold the command name, they hold the base class of the command. So it probably not hurt old files. It might hurt old macros, but I think this is not a big issue.

Yes, I proposed similar changes on Gears WB and my tests show that the objects only save the class that created them, and as long that doesn't change there is no problems.
looooo/freecad.gears#153

@hasecilu hasecilu force-pushed the fix/rename_commands branch from 5d1bdfb to fc0c969 Compare March 25, 2024 17:06
@hasecilu hasecilu marked this pull request as ready for review March 25, 2024 17:09
@hasecilu
Copy link
Contributor Author

Now the Wiki pages are being open correctly.

@hasecilu hasecilu changed the title WIP: Rename commands to coincide with Wiki pages Rename commands to coincide with Wiki pages Mar 25, 2024
@shaise shaise merged commit 9235969 into shaise:master Mar 26, 2024
shaise added a commit that referenced this pull request Mar 26, 2024
@shaise
Copy link
Owner

shaise commented Mar 26, 2024

Thanks!!

@hasecilu hasecilu deleted the fix/rename_commands branch March 30, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants