manifestTransform for dynamic routes misses catch all routes

[Pikachews]

Summary

The following snippet seems to be intended to transform the square brackets ([/]) in the file names into the respective HTML entities (%5B/%5D). However, it misses the case of catch-all routes due to trying to also matching the / preceding a [.

next-pwa/index.js

Lines 219 to 223 in 334c5de

	const manifest = manifestEntries.map(m => {
	m.url = m.url.replace(/\/\[/g, '/%5B').replace(/\]/g, '%5D')
	m.revision = buildId
	return m
	})

This ends up transforming /path/to/file/[[...slug]]-hash.js to /path/to/file/%5B[...slug%5D%5D-hash.js, which does not end up matching the request (/path/to/file/%5B%5B...slug%5D%5D-hash.js).

Not sure if there are other effects to this, but removing the forward slash from the match seems to fix the problem.

Versions

• next-pwa: 5.2.21
• next: 10.2.3

Expected Behaviors

The script should be properly cached the at installation and not requested again when the page requiring it is loaded.

Screenshots

File in the workbox-precache after PWA caches at installation:

File in the static-js-assets cache after being requested + cached:

[shadowwalker]

Fixed, update to latest version