-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and separate library into crates #345
Conversation
- shadowsocks: the core feature of shadowsocks - shadowsocks-service: local, server, manager and other tools to run shadowsocks services - shadowsocks-rust: release binaries
- ServiceContext is common parameters shared between all local implementations - Completely removed https local support
- add #292 reply attack protection
60afbc6
to
6170b9b
Compare
3616f1b
to
62ff011
Compare
faa8995
to
7cce6cd
Compare
7cce6cd
to
79876a1
Compare
adb8398
to
aa3822d
Compare
I think this PR is almost ready for shadowsocks-android. BTW, still see one warning:
|
456c21b
to
afde4bc
Compare
There still have some dependencies that migrating to tokio v0.3 are not released. |
This is a good move. But how am I supposed to use the crates from other project? It seems I can't refer to both shadowsocks and shadowsocks-service on github:
I can only clone them to local and use them:
but this is rather awkward. |
[dependencies]
shadowsocks = { git = "https://github.com/shadowsocks/shadowsocks-rust.git", branch = "master" }
shadowsocks-service = { git = "https://github.com/shadowsocks/shadowsocks-rust.git", branch = "master" } It should work. |
What is |
Just for preventing creating sockets for every queries. If the underlying network changed, which will definitely cause query failure, then the |
Does this fix shadowsocks/shadowsocks-android#2093? |
Also according to rfc7766, connection reuse can send multiple queries in a single connection. 🤔 |
Well, the |
ref #326.
This PR will also fixes #343 , #232 .