-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in docs for components (example Toast(er) ) #635
Comments
The However you need to use the import { useToast } from "@/components/ui/use-toast"
...
const { toast } = useToast(); |
Yes I know that but your feedback has nothing to do with point I'm reporting. Look closely. while the actual ui component is If you follow the exact steps from docs, you end up with a non-working example. |
Now I got it. When your run the This will be fixed in the next cli version. For now create the |
ahaa! OK seems like I took for my first testing immediately one of the components that's broken lol. Are there any other components like Toaster that are also broken in similar way? Then I can avoid those too for now 😆 PS: what is the way for contributing back to the docs if we spot something? Can we do changes and PR back? Or just report here as issue? |
Seems the only one for now.
Sure! PR are well appreciated. Just check that a PR for that issue hasn't already been submitted and you're good to go. |
Hello Shad, I'm also trying to import the toast components, but the installation code is for the Avatar components instead of Toast, please advice?? |
Hi @Tansi-Jones, there's a mistake in the docs of the toast component. To install the component simply run If you need the code for the manual installation just let me know. |
Thanks @dan5py |
I just tried following the manual installation instructions and the code that it says to copy into my project doesn't contain a component called EDIT: I've grabbed the code from the github repo rather than the website, i think it's just missing a section about the toaster component. |
@cjonesuk yeah with the new version the toast's docs is missing the additional files in the manual installation. |
The toast documentation is missing the use-toast code for the manual installation |
@feyiamujo1 Yeah, I opened an issue (#687) for that. |
Not sure if this is the best thread, it looks like the manual install of the Toast component is missing the animation/keyframes that are used in the examples. |
http://tinyurl.com/yn5pf84y |
This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you. |
Hello Shad
I was just experimenting with your library first time and was trying the Toaster component but I ran into confusing docs.
Maybe you are still in the process re-documenting stuff?
Anyway, I came across this mismatch information:
Your docs says the import has to be like
import { Toaster } from "@/components/ui/toaster"
But the actual component is not
toaster
buttoast
and raising errors.It's nothing major as I just compare the actual file names with your docs but it catches one offguard if you don't look close on the naming convention.
Is there anyway for me and others to help you spotting these changes and do a PR with the correct update for the docs?
I tried searching for the docs in your repo but I think they are not in there?
Thanks!
The text was updated successfully, but these errors were encountered: