-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: Add support for react 19 #5906
Comments
I had to abandon a Next JS 15 because this lib is not compatible with React 19 and then switched to Remix and dark mode is broken. I really hope they solve the issues. |
@sbeckerdev dark mode works perfectly on Remix for me, what problem do you have? |
The root layout is different in the last version. I followed the guide and it looks like the dark class is not applied when pressing the toggle. Can you share an example? |
@sbeckerdev I don't understand the problem. Next.js15 with React.js19 works perfectly for me! Look, I even made a Starter Kit, and from that, I created a project that should be in production within a month. |
Hey @zuher83 , I see you are using React 19, and the ShadCN components are still using the deprecated |
Hey @Kiranism Good question! Even though forwardRef is deprecated in React 19, ShadCN components still work fine because React maintains backward compatibility. |
Got it, but I'm still getting that error in the modal. :) |
I got the same error, it is about |
any updates? |
You will have to updated it yourself at least was what I did, forget forwardRef and ElementRef, and use instead |
Feature description
Is there any timeframe or plan to migrate components to react 19?
Affected component/components
Most if not all
Additional Context
The use of forwardRef on same/most components for example is forcing the need to implement some change on the component definition and integration.
Before submitting
The text was updated successfully, but these errors were encountered: