Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reader mode #24

Closed
2 tasks done
Tracked by #269
bhajneet opened this issue Apr 7, 2020 · 13 comments
Closed
2 tasks done
Tracked by #269

Add reader mode #24

bhajneet opened this issue Apr 7, 2020 · 13 comments
Labels
Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. Impacts Most Affects a majority of end-users. □ Type Story Feature or requirement written from the user's perspective using non-technical language.

Comments

@bhajneet
Copy link
Member

bhajneet commented Apr 7, 2020 •
edited by Harjot1Singh
Loading

User Persona, Goal, and Motivation

I am a traditional reader, I want to view gurbani like I would in a gutka, so that I can do paath comfortably (less scrolling and visually more natural).

Acceptance Criteria

AC1

  • Given a user is on the settings screen
  • When they toggle the reader mode element
  • Then the reader mode is toggled on/off

AC2

  • GIVEN shabad is shown
  • WHEN reader mode is toggled
  • THEN show only shabad script in paragraphs of pauris (no translations and transliterations)
  • And the font is larger

AC3

  • GIVEN reader mode is toggled
  • WHEN displaying manglacharan / header lines
  • THEN show them as individual lines in a larger font, center-aligned (see mock)

AC3 may be revisited as a future ticket, as we may not have the data available. @bhajneet to move into a new ticket.

Approach

Mockup

image

Old

Have an option to quickly switch the view to "reader mode" which may group pauris together in paragraphs, may also hide all translations, may switch to larrivaar, etc. based on whatever the user has dictated in "reader mode settings".

Could then add new issues for setting bookmarks to open in specific reader mode on a case by case or overall "type of bookmark" method.
@bhajneet bhajneet added □ Type Story Feature or requirement written from the user's perspective using non-technical language. Status: On Hold Impacts Few Does not affect many end-users. labels Apr 7, 2020
@bhajneet
Copy link
Member Author

bhajneet commented Apr 8, 2020

Toggle for switching in and out of reader mode would be hidden in drawer.

@saihaj saihaj mentioned this issue Apr 9, 2020
Open
This was referenced May 19, 2020
Closed
Closed
@saihaj saihaj moved this to Triage in Project Management Oct 24, 2021
@Harjot1Singh Harjot1Singh moved this from Triage to Requirements Analysis in Project Management Oct 24, 2021
@bhajneet bhajneet added Impacts Most Affects a majority of end-users. and removed Impacts Few Does not affect many end-users. labels Oct 30, 2021
@bhajneet bhajneet moved this from Requirements Analysis to In Refinement in Project Management Oct 30, 2021
@Harjot1Singh Harjot1Singh added the Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. label Dec 26, 2021
@Harjot1Singh Harjot1Singh moved this from In Refinement to Ready for Development in Project Management Dec 26, 2021
@Harjot1Singh Harjot1Singh mentioned this issue Feb 6, 2022
Open
3 tasks
@Harjot1Singh Harjot1Singh moved this from Ready for Development to In Progress in Project Management Mar 7, 2022
@Harjot1Singh Harjot1Singh moved this from In Progress to In Testing in Project Management Mar 8, 2022
@bhajneet
Copy link
Member Author

bhajneet commented Mar 8, 2022 •
edited
Loading

3 comments (two of which I think is easily resolvable):

  • Font size doesn't change (should be larger in reader mode)
  • No space between lines merged together
  • No title of bookmark at the top

@bhajneet bhajneet reopened this Mar 8, 2022
Repository owner moved this from In Testing to Ready for Development in Project Management Mar 8, 2022
@bhajneet
Copy link
Member Author

bhajneet commented Mar 8, 2022

Another note, which may be out of scope but should be tracked somewhere (idk whether here or new):

  • Swapping reader mode on / off loses track of position. I imagine the top line or the middle-most line in the view screen should be used as the "reading position".

@bhajneet
Copy link
Member Author

bhajneet commented Mar 8, 2022

Also, not sure how... but I got this by toggling on and off

image

@bhajneet
Copy link
Member Author

bhajneet commented Mar 8, 2022

And I have no clue how I did this one

Upload.from.GitHub.for.iOS.MOV

@bhajneet
Copy link
Member Author

bhajneet commented Mar 8, 2022

Possibly related / helpful

Upload.from.GitHub.for.iOS.MOV

@Harjot1Singh
Copy link
Member

Ah, those weird issues are all stemming from #278 - we have to fix the way the stack works by using navigate over goBack

@Harjot1Singh
Copy link
Member

The title is not part of the ACs btw! Ok with filing another ticket under the reader mode epic for this?

@Harjot1Singh
Copy link
Member

Do track a new ticket for retaining scroll position between the toggles in another ticket under the epic

@Harjot1Singh
Copy link
Member

Final question - do you have a preference on how much larger? The mocks show the original font size, except for the first few lines

@bhajneet
Copy link
Member Author

bhajneet commented Mar 8, 2022

Final question - do you have a preference on how much larger? The mocks show the original font size, except for the first few lines

For now let's do 25%. I created a ticket to investigate it further.

Harjot1Singh added a commit that referenced this issue Mar 8, 2022
@Harjot1Singh
feat: increase font size of reader mode
fafb4a4 
Related #24
Harjot1Singh added a commit that referenced this issue Mar 8, 2022
@Harjot1Singh
feat: add spacer to reader mode lines
04a1d43 
Related #24
@Harjot1Singh
Copy link
Member

Space and font have been adjusted. Will look into the bug.

@Harjot1Singh Harjot1Singh moved this from Ready for Development to In Progress in Project Management Mar 9, 2022
@Harjot1Singh Harjot1Singh moved this from In Progress to In Testing in Project Management Mar 14, 2022
@Harjot1Singh
Copy link
Member

Please re-test!

@bhajneet bhajneet moved this from In Testing to Done in Project Management Mar 16, 2022
@Harjot1Singh Harjot1Singh moved this from Done to In Testing in Project Management Mar 27, 2022
@Harjot1Singh Harjot1Singh moved this from In Testing to Done in Project Management Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. Impacts Most Affects a majority of end-users. □ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
Project Management
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Harjot1Singh @bhajneet