Improve logging #327
Merged
Improve logging #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh4nks
approved these changes
Sep 5, 2017
|
Sounds good, if no log file path is given, then we can prompt for the default. Alternatively, I think fileConfig can be called multiple times to configure iteratively and we could store as many as the user wants |
justanr
force-pushed
the
Improve-Logging
branch
from
fc16b06 to
89ca312
Compare
# Conflicts: # flaskbb/utils/requirements.py
# Conflicts: # flaskbb/utils/populate.py
# Conflicts: # flaskbb/configs/default.py # flaskbb/management/models.py # flaskbb/utils/helpers.py
justanr
commented
Nov 18, 2017
| formatter = logging.Formatter( | ||
| '%(asctime)s %(levelname)s: %(message)s ' | ||
| '[in %(pathname)s:%(lineno)d]') | ||
| app.config.get('LOG_FORMAT') or default_log_format |
There was a problem hiding this comment.
The dict.get(...) or ... pattern prevents things like the key exists but it's set to None or ''
| @@ -615,6 +616,14 @@ def generate_config(development, output, force): | |||
| click.style("Mail Admin Email", fg="magenta"), | |||
| default=default_conf.get("mail_admin_address")) | |||
|
|
|||
| click.secho("Optional filepath to load a logging configuration file from. " | |||
There was a problem hiding this comment.
Should I add the other new log config options here as well?
There was a problem hiding this comment.
I think that would be an overkill for our guided setup - just the file is fine imo
There was a problem hiding this comment.
Alright, I'll update the docs to call these out then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch of loggers and an option to load a log configuration file (either through envvars, a .cfg file, or the python config file). This puts more power in the hands of users to control their logging rather than just rotating files or SMTP (which are preserved).
What do we log now?