Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename chunk_width to samples_chunk_size and chunk_length to variants_chunk_size (or similar) #73

Closed
jeromekelleher opened this issue Mar 11, 2024 · 3 comments

Comments

@jeromekelleher
Copy link
Contributor

I find it unhelpful adding different dimensions here which don't actually line up with the named xarray dimensions. I think we should use the named dimensions here in some way, rather than "length" and "width".

Options:

  • chunk_variants, chunk_samples
  • variants_chunk_size, samples_chunk_size
  • ...

I don't really know what's the best choice here.

Any thoughts @tomwhite @benjeffery?

@tomwhite
Copy link
Contributor

+1 to changing the names. I vote for variants_chunk_size and samples_chunk_size.

@benjeffery
Copy link
Contributor

Yep, agreed that the dimensions should be named

@jeromekelleher
Copy link
Contributor Author

OK, variants_chunk_size and samples_chunk_size it is. Should be simple search and replace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants