payara#4281 Removed expiration of session from isValid getter

- implementation reflects javadoc now - fixes deadlock caused by side effect of getter
sgflt · Feb 9, 2020 · 9129d9f · 9129d9f
1 parent 1aee9ce
commit 9129d9f
Showing 1 changed file with 1 addition and 16 deletions.
diff --git a/appserver/web/web-core/src/main/java/org/apache/catalina/session/StandardSession.java b/appserver/web/web-core/src/main/java/org/apache/catalina/session/StandardSession.java
@@ -716,22 +716,7 @@ public boolean isValid() {
             return true;
         }
 
-        /* SJSAS 6329289
-        if (maxInactiveInterval >= 0) {
-            long timeNow = System.currentTimeMillis();
-            int timeIdle = (int) ((timeNow - thisAccessedTime) / 1000L);
-            if (timeIdle >= maxInactiveInterval) {
-                expire(true);
-            }
-        }
-        */
-        // START SJSAS 6329289
-        if (hasExpired()) {
-            expire(true);
-        }
-        // END SJSAS 6329289
-
-        return (this.isValid);
+        return this.isValid;
     }
 
     // START CR 6363689