Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolchain): add alias indirection for gvm toolchain #82

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

sgammon
Copy link
Owner

@sgammon sgammon commented Sep 1, 2023

Summary

This changeset adds alias targets and an additional level of indirection behind the GVM toolchain, to match the Java toolchain structure, as requested in #66.

Breaking changes

When registering toolchains in a Bzlmod installation of these rules, the target @graalvm//:all must be changed to two toolchain registrations, based on the desired functionality:

Register the Java toolchain:

register_toolchains("@graalvm//:jvm")

Register the GVM toolchain:

register_toolchains("@graalvm//:sdk")

Fixes and closes #66. Targeting release in #80.

- fix: add `gvm` toolchain to toolchain config repo
- fix: add aliases from `graalvm` → toolchain targets
- fix: adjust instructions for registering toolchains
- fix: adjust workspace toolchain registration logic

Breaking change:
When registering toolchains in a Bzlmod installation of these rules,
the target `@graalvm//:all` must be changed to two toolchain
registrations, based on the desired functionality:

  Register the Java toolchain:
  register_toolchains("@graalvm//:jvm")

  Register the GVM toolchain:
  register_toolchains("@graalvm//:sdk")

Fixes and closes #66.

Relates-To: #66
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon added enhancement New feature or request 🚧 WIP Work-in-progress, do not merge toolchains labels Sep 1, 2023
@sgammon sgammon added this to the 1.0.0 milestone Sep 1, 2023
@sgammon sgammon self-assigned this Sep 1, 2023
@sgammon sgammon linked an issue Sep 1, 2023 that may be closed by this pull request
@sgammon sgammon changed the title fix!: add alias indirection for gvm toolchain fix(toolchain): add alias indirection for gvm toolchain Sep 1, 2023
@sgammon sgammon mentioned this pull request Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sgammon sgammon marked this pull request as ready for review September 1, 2023 20:56
@sgammon sgammon merged commit 5de7f5f into release/0.10.x Sep 1, 2023
50 checks passed
@sgammon sgammon removed the 🚧 WIP Work-in-progress, do not merge label Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request toolchains
Projects
Development

Successfully merging this pull request may close these issues.

Download GraalVM distributions lazily
1 participant