-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample JACK client (sfizz_jack) goes into infinite loop on EOF #1266
Comments
Just tried this on current git version. Same behaviour and can also be reproduced by redirecting stdin from /dev/null. |
The REPL loop seems to be here if anyone knows how to fix it to properly detect EOF and exit: Line 222 in 806bf1d
In the meantime, my workaround is to send it an empty string and newline once per minute like this: |
@acli In my personal opinion, the client should not quit by Ctrl-D or EOF in order to run as a background job. |
@KKQ-KKQ I have a patch too (actually three; I tried a few different ways). It’s still open after one and a half months; I’m supposing they’re too busy. |
@GeoffreyPlitt Fixing this will not (and should not) allow it to run as a demon. When it detects EOF the CLI thread ends and the program will (should) exit. I think what you need is a flag to disable the CLI. I should be able to make you an unofficial patch but it’s been more than a month since I touched this. (My computer is too slow to do SFZ; I’ve sort of given up.) |
sfizz-1.2.3 compiled with gcc 11. If I start sfizz_jack and then hit ctrl-d to try to end the program, sfizz_jack instead goes into an infinite loop and I’ll have to hit ctrl-c to stop it.
Example (ctrl-d was pressed on line 54, i.e., immediately after I got a prompt):
The text was updated successfully, but these errors were encountered: