Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio clipping #6

Open
mmontag opened this issue Jun 14, 2024 · 3 comments
Open

Audio clipping #6

mmontag opened this issue Jun 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mmontag
Copy link

mmontag commented Jun 14, 2024

Hi, I'm sorry to be harsh, but the sound clips so easily that it's almost unusable.
Can you add a gain control and significantly reduce the default output level?

@kmturley
Copy link
Collaborator

Hello, it is not harsh to provide valuable feedback.
Can you provide more information about the machine/browser you are using and which instrument so I can try to replicate?

This sfz-web-player is a prototype so does not have many audio effects/controls implemented yet

Here is a video showing notes played with a volume indicator. Looks ok to me at first glance:
https://github.com/sfzlab/sfz-web-player/assets/1710493/657daf46-bbb3-4ef7-b850-03754678afeb

It would be fairly easy to add a volume control if using your overall machine volume is not sufficient

@mmontag
Copy link
Author

mmontag commented Jun 14, 2024

I don't think it is machine/browser specific, but I could be wrong. I think the engine is internally clipping. (Turning down the system volume does not alleviate the clipping)

I am just loading up the page with the default instrument, which sounds like Kalimba, and then clicking my mouse across all the notes. As soon as 3-4 notes are playing simultaneously, it sounds like clipping to me.

@kmturley
Copy link
Collaborator

Ah yes I can replicate. Playing multiple notes together does cause distortion/clipping.
Will add as a bug to fix

@kmturley kmturley added the bug Something isn't working label Jun 14, 2024
@kmturley kmturley self-assigned this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants