Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should indicate and prevent duplicate task for same benchmark and para #450

Open
canjalal opened this issue Oct 16, 2024 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@canjalal
Copy link
Contributor

canjalal commented Oct 16, 2024

ACTUAL

If case manager attempts to assign a benchmark to Para "A", then tries to assign the benchmark to Para "A" once more, the UI will allow them to (checkbox is empty next to name).

Furthermore, instead of showing an error, the app allows the case manager to actually create a duplicate task assigned to Para "A". This results in a duplicate row in the tasks table.

As of finishing #439 (backend solution), we now see this error which does prevent duplicate task creation.
image

EXPECTED

If case manager attempts to assign a benchmark to Para "A", then tries to assign the benchmark to Para "A" once more, the UI will show a checkbox next to their name b/c they are already assigned. The case manager can then choose to uncheck or recheck the checkbox to unassign or reassign.

Furthermore, if the front end UI checks are broken or bypassed, the app should not allow the case manager to actually create a duplicate task assigned to Para "A". Duplicate rows in the tasks table should not be created no matter what.

Notes:

In the beginning, the fetching of a benchmark should also fetch all paras assigned to said benchmark through tasks

Unassigning a para will delete a task

trial_data should be associated with a benchmark_id rather than a task_id

@canjalal canjalal added this to Compass Oct 16, 2024
@canjalal canjalal converted this from a draft issue Oct 16, 2024
@canjalal canjalal self-assigned this Oct 16, 2024
@canjalal
Copy link
Contributor Author

Blocked by #439

@canjalal
Copy link
Contributor Author

Do we want to be able to unassign benchmarks? If we do this, it will destroy the data on the due_date, trial_count, and the seen flag.

@canjalal canjalal moved this from Backlog to Blocked / On hold in Compass Oct 18, 2024
@canjalal canjalal added the blocked Blocked by another issue (please mention in ticket) label Oct 18, 2024
@canjalal canjalal removed the status in Compass Oct 29, 2024
@canjalal canjalal moved this to Ready for Dev in Compass Oct 29, 2024
@canjalal canjalal added bug Something isn't working and removed blocked Blocked by another issue (please mention in ticket) labels Oct 29, 2024
@canjalal
Copy link
Contributor Author

Will do #465 before working on this

@canjalal canjalal added the blocked Blocked by another issue (please mention in ticket) label Nov 14, 2024
@canjalal canjalal removed the blocked Blocked by another issue (please mention in ticket) label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready for Dev
Development

No branches or pull requests

1 participant