Remove dynamic allocation of atomic #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since sfackler#1925 building static binaries fails because of a hardcoded `dylib`. Removing the `dylib` but still let rust search for the dependency it will still link it. This should still keep sfackler#1645 fixed but also fixes sfackler#2043. I have tested this by building Vaultwarden for both dynamically linked debian based image, and a statically linked musl/alpine based image. But are using OpenSSL v3.x.x.
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Nov 14, 2023
Updated crates and adjusted code where needed. One major update is Rocket rc4, no need anymore (again) for crates.io patching. The only item still pending is openssl/openssl-sys for which we need to wait if sfackler/rust-openssl#2094 will be merged. If, then we can remove the pinned versions for the openssl crate.
dani-garcia
pushed a commit
to dani-garcia/vaultwarden
that referenced
this pull request
Nov 15, 2023
* Remove another header for websocket connections * Fix small bake issue * Update crates Updated crates and adjusted code where needed. One major update is Rocket rc4, no need anymore (again) for crates.io patching. The only item still pending is openssl/openssl-sys for which we need to wait if sfackler/rust-openssl#2094 will be merged. If, then we can remove the pinned versions for the openssl crate.
|
@sfackler anything holding this back from being merged? |
|
Sorry - GMail decided to send all of my rust-openssl emails to the spam folder :( |
Ah, that sux. Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1925 building static binaries fails because of a hardcoded
dylib. Removing thedylibbut still let rust search for the dependency it will still link it, but then statically.This should still keep #1645 fixed but also fixes #2043.
I have tested this by building Vaultwarden for both dynamically linked debian based image, and a statically linked musl/alpine based image. Both are using OpenSSL v3.x.x.
Closes #2058