Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the registry/repo for the image #2

Closed
wants to merge 9 commits into from
Closed

Conversation

ram-vibhul
Copy link

No description provided.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@oskar-s9s
Copy link
Collaborator

Given you configured a public repo now, shouldn't we restrict the image pushes at least to main branch?

@ram-vibhul ram-vibhul marked this pull request as draft March 20, 2024 08:41
@ram-vibhul
Copy link
Author

Given you configured a public repo now, shouldn't we restrict the image pushes at least to main branch?

done

@ram-vibhul ram-vibhul marked this pull request as ready for review April 5, 2024 09:02
@oskar-s9s
Copy link
Collaborator

Hey @ram-vibhul ,
As you might noticed this pr is already obsolete given cmon images are pushed to dockerhub and we don't wat to change that.
If you still want to push this to Google public repo, please create a new workflow and create a new pr :-)

@oskar-s9s oskar-s9s closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants