-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requests 2.32.0+ does not work with truststore library #165
Comments
@sethmlarson if you find some time I would appreciate if you could have a look 🙏 |
@sethmlarson do you have a timeline when this will be released? :) |
I can work on a release, there's another change that should get distributed too. |
Published a release: https://pypi.org/project/truststore/0.10.1/ |
Thanks a lot 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Starting with the release 2.32.0 of the requests library the truststore library always leads to an recursion error. I was able to reproduce this on different Windows, Linux (Ubuntu) and macOS machines.
The crulpit seems to be the added "preloaded ssl context", which does not work well with truststore injection. While it seems to use urllib3 under the hood, the patched SSLContext is not really used.
Fix
Proposed fix is to import the
requests.adapter
package and patch the context accordingly with a truststore patched SSLContext, finished up in #164Related
inject_into_ssl()
not working in virtual environment (Windows 10) #155The text was updated successfully, but these errors were encountered: