Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix char boundary bug #139

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Fix char boundary bug #139

merged 3 commits into from
Dec 16, 2024

Conversation

A-Walrus
Copy link
Contributor

Fixes #138

Set all bytes of char to prev_level.

Set all bytes of char to prev_level
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but could you add some tests?

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, thanks for the work!!

@@ -2041,6 +2041,22 @@ mod tests {
.collect()
}

#[test]
#[cfg(feature = "hardcoded-data")]
fn test_reordered_levels_range() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: link to the issue in a comment?

@Manishearth Manishearth merged commit 75a760c into servo:main Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visual_range can return invalid ranges leading to indexing panic
2 participants