Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.45.0 CI job fails to build after latest updates to serde and serde_derive crates #785

Closed
ridwanabdillahi opened this issue Aug 16, 2022 · 1 comment

Comments

@ridwanabdillahi
Copy link
Contributor

Describe the bug
The Rust 1.45.0 CI job has started failing due to an update of the serde and serde_derive crates. The latest updates to these crates causes cargo to require the resolver feature which was unstable in the version of cargo shipped in the Rust 1.45.0 toolchain.

This feature was stabilized in the version of cargo shipped with the Rust 1.51.0 toolchain.

Example of failure:

cargo build --all-targets
warning: /src/rust-url/url/Cargo.toml: unused manifest key: package.rust-version
warning: /src/rust-url/data-url/Cargo.toml: unused manifest key: package.rust-version
warning: /src/rust-url/percent_encoding/Cargo.toml: unused manifest key: package.rust-version
warning: /src/rust-url/idna/Cargo.toml: unused manifest key: package.rust-version
warning: /src/rust-url/form_urlencoded/Cargo.toml: unused manifest key: package.rust-version
error: failed to download `serde v1.0.143`

Caused by:
  unable to get packages from source

Caused by:
  failed to parse manifest at `/home/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/serde-1.0.143/Cargo.toml`

Caused by:
  feature `resolver` is required

this Cargo does not support nightly features, but if you
switch to nightly channel you can add
`cargo-features = ["resolver"]` to enable this feature

The Cargo.toml specified in the build failure now includes the manifest key, resolver = "1".

@ridwanabdillahi
Copy link
Contributor Author

The minimum rust-version for the url crate has been upgraded to 1.51 to ensure clean CI jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant