Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build with new versions of cc-rs when using sccache #38

Open
jdm opened this issue May 1, 2020 · 2 comments · May be fixed by #40
Open

Can't build with new versions of cc-rs when using sccache #38

jdm opened this issue May 1, 2020 · 2 comments · May be fixed by #40

Comments

@jdm
Copy link
Member

jdm commented May 1, 2020

Linux builds break with this error:

running: "sccache" "clang++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=x86_64-unknown-linux-gnu" "-I" "gfx/angle/checkout/include/" "-I" "gfx/angle/checkout/out/gen/angle/" "-I" "gfx/angle/checkout/src/" "-I" "gfx/angle/checkout/src/common/third_party/base/" "-std=c++14" "-msse2" "-DANGLE_ENABLE_DEBUG_ANNOTATIONS" "-DANGLE_ENABLE_ESSL" "-DANGLE_ENABLE_GLSL" "-DANGLE_ENABLE_HLSL" "-DANGLE_ENABLE_KEYEDMUTEX" "-DANGLE_SKIP_DXGI_1_2_CHECK" "-DDYNAMIC_ANNOTATIONS_ENABLED=1" "-DNOMINMAX" "-DNTDDI_VERSION=0x0A000003" "-DUNICODE" "-DWINVER=0x0A00" "-D_ATL_NO_OPENGL" "-D_CRT_RAND_S" "-D_CRT_SECURE_NO_DEPRECATE" "-D_HAS_EXCEPTIONS=0" "-D_SCL_SECURE_NO_DEPRECATE" "-D_SECURE_ATL" "-D_UNICODE" "-D__NDK_FPABI__=" "-o" "/repo/target/debug/build/mozangle-b2466e97cbb8dddf/out/gfx/angle/checkout/src/common/third_party/xxhash/xxhash.o" "-c" "gfx/angle/checkout/src/common/third_party/xxhash/xxhash.c"
exit code: 0
cargo:warning=error: invalid argument '-std=c++14' not allowed with 'C'
exit code: 1

Building with updated cc-rs and without sccache does not trigger this error. I suspect rust-lang/cc-rs@4b72474 triggers the change in behaviour.

@jdm
Copy link
Member Author

jdm commented May 1, 2020

I'm experimenting with alternatives in https://github.com/servo/mozangle/compare/master...jdm-patch-4?quick_pull=1.

@jdm
Copy link
Member Author

jdm commented Jun 26, 2020

I've tracked down the cause of the behaviour change to mozilla/sccache#803. We will hopefully be able to work around it by forcing C++ mode when building with clang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant