Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macos: Make sure to decrement the ref count of the mach port on ChannelClosed #116

Open
dlrobertson opened this issue Nov 8, 2016 · 0 comments
Open

macos: Make sure to decrement the ref count of the mach port on ChannelClosed #116

dlrobertson opened this issue Nov 8, 2016 · 0 comments

Comments

@dlrobertson
Copy link
Contributor

Similar to what is seen in #96 we should ensure that we do not have mach port leaks on ChannelClosed.

We should also use an auto-incrementing number as an id instead of the local_port cast to a u64(here and here) to avoid a race condition if the mach port number is reused. I do not know mach ports well enough to know if this is necessary yet.

Related to: #96 #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dlrobertson