Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard error types with duplicate https scheme #954

Closed
matthias-pichler opened this issue Aug 4, 2024 · 1 comment · Fixed by #957
Closed

Standard error types with duplicate https scheme #954

matthias-pichler opened this issue Aug 4, 2024 · 1 comment · Fixed by #957
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: fix Something isn't working. Impacts in a minor version change.
Milestone

Comments

@matthias-pichler
Copy link
Collaborator

matthias-pichler commented Aug 4, 2024

What seems off:

Why are error types specified with a repeated https at the beginning: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#standard-error-types? E.g https://https://serverlessworkflow.io/spec/1.0.0/errors/validation

What you expected to be:

Since the format is specified as a uri-template in the schema I would expect a valid URI

Anything else we need to know?:

Why are the error types of format uri-template and not uri in the first place? Because the context against which the template should be evaluated isn't documented either

Environment:

  • Specification version used: 1.0.0-alpha2
@cdavernas
Copy link
Member

It's a typo, good catch!

@cdavernas cdavernas added change: fix Something isn't working. Impacts in a minor version change. change: documentation Improvements or additions to documentation. It won't impact a version change. area: spec Changes in the Specification labels Aug 4, 2024
@cdavernas cdavernas added this to the v1.0.0-alpha3 milestone Aug 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: fix Something isn't working. Impacts in a minor version change.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants