Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noisy coverage statistics #132

Open
danieleades opened this issue Jan 10, 2025 · 0 comments
Open

noisy coverage statistics #132

danieleades opened this issue Jan 10, 2025 · 0 comments

Comments

@danieleades
Copy link
Contributor

the coverage metrics seem to be a bit all over the place. This could be because some of the uploads to codecov are failing.

This can occur due to github's rate limiting API, and this is silent since by default the codecov action doesn't fail the job if the upload fails.

The best way to address this is to add the CODECOV_TOKEN to the repository secrets. When uploading using this token, there's no rate-limiting and this failure mode can no longer occur.

https://docs.codecov.com/docs/adding-the-codecov-token

You can also configure the codecov action to fail the build if the upload fails.

      - name: Upload coverage to Codecov
        uses: codecov/codecov-action@v4
        with:
          token: ${{ secrets.CODECOV_TOKEN }}
          files: lcov.info
          flags: ${{ matrix.crate }}
          fail_ci_if_error: true

I'd suggest doing both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant