Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace json-schema-to-typescript by quicktype #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fredericbarthelet
Copy link
Contributor

Closes: #1

@fredericbarthelet fredericbarthelet force-pushed the exp-quicktype branch 3 times, most recently from 92fe40d to aa0c3dc Compare December 24, 2020 13:56
@fredericbarthelet fredericbarthelet changed the title Add quicktype, typescript source code and eslint Replace json-schema-to-typescript by quicktype Dec 24, 2020
Copy link

@Michael-Hering Michael-Hering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this fix #27 as well?

@bfaulk96
Copy link

bfaulk96 commented Mar 7, 2022

Any reason this was never considered/merged?

@fredericbarthelet
Copy link
Contributor Author

Hi @bfaulk96, as you can see in the linked issue #1, Quicktype is misbehaving regarding JSON Schema additionalProperties specification. You can find additional details on glideapps/quicktype#1615

@RichiCoder1
Copy link

@fredericbarthelet it looks like the blocking issue was finally merged. Worth reviving this PR and trying again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solving definitions issues
4 participants