Adding -f and -i to requirements.txt options ignore list before sorting #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paddycarey I believe this will fix your requirements.txt problem... |
|
This seems to fix my problem, my private packages now install correctly, thanks! |
dschep
approved these changes
Sep 13, 2018
Merged
dschep
added a commit
that referenced
this pull request
Sep 14, 2018
* Don't skip non-docker tests when docker isn't present * Don't hard code a static cache md5sum @AndrewFarley, I noticed that tests were failing on #238 and got the same errors locally on `master`. Do you think it's reasonable to compute the md5sum this way? I don't like hard coding the hash. But, I understand that this makes the test verify less of the process. Best would probably be to externally replicate what `genrerateRequirementsFile` does to create a new file and md5sum that instead of `.serverless/requirements.txt`
|
Should |
|
@dschep No, -e is a line prefix, not a whole file prefix. Any/every line can be prefixed with -e. I'd recommend that individual try this merge request however. Thanks for looking out though. I'll go look into his issue now see if I can replicate and debug /fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #236 (again, properly)
Problem: requirements.txt options which must be in the proper order at the start of the file were being sorted. This properly skips sorting them and keeps them in order they were.