feat: support uv-managed projects #850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfgordon2
commented
Oct 2, 2024
| stderr.includes( | ||
| stdout.includes( |
There was a problem hiding this comment.
Something weird is going on here that, despite being thrown as throw new serverless.classes.Error it is being output on stdout instead of stderr. I'm uncertain of the cause, but I don't think it's related to this plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #849
Adds support for uv managed projects, following the project's existing pattern of exporting a requirements file using the relevant project tool.
This does buck one-convention in this repo, in that it requires the user to have generated their own lock file, which is generally a best-practice when using one of these project management tools, and inspects for the existence of the
uv.lockfile as part of its check as to whether or not uv can be utilized with this plugin. This could be an issue for teams that are not otherwise committing their lock files to their repos and have automated deployments of their application in a CI/CD pipeline, although there exists trivial solutions to overcome that barrier.Note: there is another issue, #830, which also asks for uv support in replacing pip, which this PR does not intend to include.