Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default webpackConfig.node should be false #502

Merged
merged 6 commits into from
May 10, 2020

Conversation

stevemao
Copy link
Contributor

@stevemao stevemao commented May 20, 2019

completely turn off the NodeStuffPlugin and NodeSourcePlugin plugins.

We don't want webpack to mock node globals

See https://codeburst.io/use-webpack-with-dirname-correctly-4cad3b265a92 and https://webpack.js.org/configuration/node

What did you implement:

Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

completely turn off the NodeStuffPlugin and NodeSourcePlugin plugins.

We don't want webpack to mock node globals

See https://codeburst.io/use-webpack-with-dirname-correctly-4cad3b265a92 and https://webpack.js.org/configuration/node
@HyperBrain
Copy link
Member

Good catch 👍 . Could you please add the check for the default value to the unit tests to keep up the coverage and complete the checklist above (TODOS)?

@HyperBrain HyperBrain added this to the 5.4.0 milestone May 20, 2019
Copy link
Member

@HyperBrain HyperBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fulfills the marge requirements 👍

@HyperBrain
Copy link
Member

HyperBrain commented Jun 2, 2019

I'm waiting with the merge, because a fix for #505 might still go into 5.3.1 as it is urgent but this one is for 5.4.0 as it is a feature by nature, not a bug fix that does not change the expectations.

@miguel-a-calles-mba miguel-a-calles-mba changed the base branch from master to release/5.4.0 May 6, 2020 23:13
@miguel-a-calles-mba miguel-a-calles-mba modified the milestones: 5.4.0, 5.3.3 May 10, 2020
@miguel-a-calles-mba miguel-a-calles-mba changed the base branch from release/5.4.0 to release/5.3.3 May 10, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants