-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default webpackConfig.node should be false #502
default webpackConfig.node should be false #502
Conversation
completely turn off the NodeStuffPlugin and NodeSourcePlugin plugins. We don't want webpack to mock node globals See https://codeburst.io/use-webpack-with-dirname-correctly-4cad3b265a92 and https://webpack.js.org/configuration/node
Good catch 👍 . Could you please add the check for the default value to the unit tests to keep up the coverage and complete the checklist above (TODOS)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and fulfills the marge requirements 👍
I'm waiting with the merge, because a fix for #505 might still go into 5.3.1 as it is urgent but this one is for 5.4.0 as it is a feature by nature, not a bug fix that does not change the expectations. |
completely turn off the NodeStuffPlugin and NodeSourcePlugin plugins.
We don't want webpack to mock node globals
See https://codeburst.io/use-webpack-with-dirname-correctly-4cad3b265a92 and https://webpack.js.org/configuration/node
What did you implement:
Closes #XXXXX
How did you implement it:
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO