Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for webpack 5 support (backward compatible) #472

Merged
merged 9 commits into from
Apr 24, 2019
Merged

Fixes for webpack 5 support (backward compatible) #472

merged 9 commits into from
Apr 24, 2019

Conversation

neilime
Copy link
Contributor

@neilime neilime commented Jan 9, 2019

What did you implement:

Webpack 5 removes deprecated functions, and add some minor changes that broke up this plugin

How did you implement it:

  • Uses modulesIterable instead of forEachModule (already deprecated in version 4)
  • Iterate over chunks with for ... of because stats.compilation.chunks is a Set now

How can we verify it:

Install webpack 5
run sls package

An error occured : Cannot read property 'forEachModule' of undefined

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

neilime and others added 2 commits January 9, 2019 12:34
* Uses `modulesIterable` instead of `forEachModule` (already deprecated in version 4)
* Iterate over chunks with `for ... of`` because stats.compilation.chunks is a `Set`
@neilime neilime changed the title Fixes for webpack 5 support Fixes for webpack 5 support (backward compatible) Jan 10, 2019
@HyperBrain HyperBrain added this to the 5.3.0 milestone Apr 7, 2019
@HyperBrain
Copy link
Member

@serverless-heaven/serverless-webpack-contributors Can anyone of you confirm, that this PR continues to work with old webpack versions?

@hassankhan
Copy link
Contributor

hassankhan commented Apr 19, 2019

@HyperBrain just tested it on my projects using Webpack v4.x, all seems to be working fine.

Copy link
Contributor

@hassankhan hassankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code all looks good, getting a few lint errors on the branch. Aside from that, LGTM 👍

@HyperBrain
Copy link
Member

HyperBrain commented Apr 21, 2019

@hassankhan Hmmm. It seems that Travis is not working any longer for the project. I'll check. We should get it running again, as it also checks for linter errors and blocks merges. Found the issue and reset the project settings

@HyperBrain
Copy link
Member

@neilime Travis now works again - and stopped at the linter issues. Could you please address the issues?

@neilime
Copy link
Contributor Author

neilime commented Apr 22, 2019

@HyperBrain, it's done.

@hassankhan
Copy link
Contributor

hassankhan commented Apr 22, 2019

Hi @neilime, thanks for fixing the lint issues. Unfortunately, it seems test coverage has decreased (as noted by the failed coverage/coveralls check, would you mind having a quick look at those too?

@neilime
Copy link
Contributor Author

neilime commented Apr 23, 2019

@hassankhan, it's done.

@neilime
Copy link
Contributor Author

neilime commented Apr 23, 2019

You're right @hassankhan, I have change the code

@HyperBrain HyperBrain merged commit 9550751 into serverless-heaven:master Apr 24, 2019
@neilime neilime deleted the patch-2 branch April 24, 2019 19:05
@HyperBrain HyperBrain mentioned this pull request Apr 30, 2019
@HyperBrain
Copy link
Member

Released with 5.3.0

jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
Fixes for webpack 5 support (backward compatible)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants