Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #664
Allow custom runtime if Nodejs based.
How did you implement it:
Those are the proposed changes:
We add an additional property to allow a custom runtime only if the user sets this to
true
And then add another check:
How can we verify it:
You can check this repository https://github.com/MatteoGioioso/serverless-webpack-bug
Without this feature
runtime: provided
and use the latest version of serverless-webpackserverless-webpack/lib/validate.js
Line 104 in 69dfc3f
Therefore it will package the entire project. You can inspect the
.serverless
folder after the packaging has completedWith this feature
runtime: provided
andallowCustomRuntime: true
with the version of this branchThe function will be packaged like normally. You can inspect the result in the
.serverless
folder after the packaging has completedI have added a test as well to check this condition and updated the documentation.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO