-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-sdk: warning on deployment #393
Comments
Hi @shavo007 , thanks for the report 👍 . This warning is expected, because I improved the dependency detection to be able to find common issues where dependencies are set in devDependencies instead of dependencies (I treated this missing behavior as a bug, because it could lead to defunctional deployments). These issues are very hard to track down, because previously they only led to crashes when deployed. To get rid of the warning and have a correct project setup you should set the aws-sdk as forcefully excluded. This explicitly states that it is not deployed intentionally (as the serverless.yml is declarative, this is then more correct than silently excluding it). So, just add:
in your serverless.yml and the warning will be gone and it expresses, what is happening and what is intended. |
I'll change the issue subject, so that others who recognize the warning can lookup and find it more easily. |
hi @HyperBrain thanks for the response. Issue is that it is correctly defined as a dev dependency (aws lambda includes aws-sdk in container). see https://docs.aws.amazon.com/lambda/latest/dg/current-supported-versions.html That is why i do not have it as a dependency. When i see a warning in my CI server i assume there is a problem. What you think? |
@shavo007 As I wrote, there is no problem and you defined it correctly in devDependencies 😃 . The warning is only a hint that aws-sdk should be set as forceExclude to let the system know that you intended to have it that way (which is fully normal for it). The only thing you should do is, to define the |
tbh @HyperBrain im just not a big fan of this change! i shoudnt have to declaratively exclude aws-sdk to resolve the warning. When in fact I am doing the right thing and defining it as a dev dependency. Why have this warning in the first place? Why not have a whitelist and exclude aws-sdk? Thoughts? |
@shavo007 What we could do is, to restrict the warning to only show up with |
@HyperBrain info sounds good. but thats just my opinion!! |
This is a Bug Report
Description
Updated webpack serverless and now get warning when deploying
Config:
Similar or dependent issue(s):
Additional Data
The text was updated successfully, but these errors were encountered: