-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serverless create template #137
Comments
Wow. Nice idea 🙌 . That would make the project creation really easy. Then we can work and comment on a PR there - that one of us (maybe you 😄 ) initially created to get a nice template in there. |
Yes @HyperBrain |
@franciscocpg 2.1.0 is out now! Maybe you can proceed here as soon as you have some time. |
Sure @HyperBrain |
Oh and maybe we need to add a |
... and #167 will remove the extension from the entry key names in |
see also the discussion in #158 |
So I think it's better wait for 2.2.0. |
2.2.0 is out. Had to be that fast, because of the TypeScript issue with the entries export 😃 . You can proceed here now. |
I agree that there should be more than one template - the multi-static and the typescript. We can add one that is missing later: the multi-dynamic, as soon as it is proven that the entries detection works properly now. Imo the dynamic template(s) should be the preferred ones in the future. |
@HyperBrain |
I would use the dynamic sample. Imo this is the preferred way now to configure the plugin/webpack in an easy and safe way. Much easier than finding out and adding new entries or removing stale ones when you add or remove functions. The manual configuration is very error-prone, especially when it comes to individual packaging and optimization in V3, which works like a charm with lib.entries. But yes, ES and TS should be the choice for them. |
Ops, I've put the wrong example. |
I would prefer babel-dynamically-entries. Both samples TS and ES should use lib.entries for the entry definition. |
Oh. did not refresh 😄 ... yes, right |
👍 |
BTW: The lib extensions are really a great thing - did you see that I extended it with |
@HyperBrain
|
I already merged #179 . It would be great if you open proper issues at SLS and link them here. |
👍 |
Adding |
@HyperBrain |
Yes. We should 😊
Currently github.com does not work for me, so my reply is from mail…
@HyperBrain <https://github.com/hyperbrain>
Both PRs are merged.
SHould we close this issue right now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#137 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFRM3oPhpaY1ckC0W90DUrIbM8peMKadks5saYh-gaJpZM4OKtzy>
.
|
In the future we could add a template here so that new serverless projects can be created with webpack already configured.
The text was updated successfully, but these errors were encountered: